------------------------------------------------------------------------ r368289 | jhb | 2020-12-02 15:16:24 -0800 (Wed, 02 Dec 2020) | 5 lines MFC 355686: Fix a mismerge in r355683 and remove the local gdb_port from main. PR: 251501 Reported by: Yuichiro NAITO ------------------------------------------------------------------------ r368291 | lwhsu | 2020-12-02 18:21:48 -0800 (Wed, 02 Dec 2020) | 12 lines MFC r367812: ipheth(4): Fix for iOS 14 Fix USB tethering for iOS 14. Inspired by: https://github.com/libimobiledevice/libimobiledevice/issues/1038 PR: 249979 Reviewed by: hselasky Differential Revision: https://reviews.freebsd.org/D27250 ------------------------------------------------------------------------ r368295 | cy | 2020-12-02 21:56:42 -0800 (Wed, 02 Dec 2020) | 4 lines MFC r366286: ipfilter getifname ifdef cleanup. ------------------------------------------------------------------------ r368297 | hselasky | 2020-12-03 02:32:54 -0800 (Thu, 03 Dec 2020) | 16 lines MFC r368058: Ensure consistent error messages from ifconfig(8). If multiple threads are invoking "ifconfig XXX create" a race may occur which can lead to two different error messages for the same error. a) ifconfig: SIOCIFCREATE2: File exists b) ifconfig: interface XXX already exists This patch ensures ifconfig prints the same error code for the same case. Reviewed by: imp@ and kib@ Differential Revision: https://reviews.freebsd.org/D27380 Sponsored by: Mellanox Technologies // NVIDIA Networking ------------------------------------------------------------------------ r368301 | mhorne | 2020-12-03 06:04:42 -0800 (Thu, 03 Dec 2020) | 3 lines MFC r367734: bsdiff: fix off-by-one error ------------------------------------------------------------------------ r368303 | markj | 2020-12-03 07:54:41 -0800 (Thu, 03 Dec 2020) | 3 lines MFC r368194: qat: Initialize the crypto device ID to -1 instead of 0 ------------------------------------------------------------------------ r368304 | markj | 2020-12-03 07:55:07 -0800 (Thu, 03 Dec 2020) | 3 lines MFC r368193: qat: Fix firmware module autoloading ------------------------------------------------------------------------ r368318 | kib | 2020-12-03 16:48:11 -0800 (Thu, 03 Dec 2020) | 3 lines MFC r367895: msdosfs: suspend around unmount or remount rw->ro. ------------------------------------------------------------------------ r368319 | jhb | 2020-12-03 17:09:51 -0800 (Thu, 03 Dec 2020) | 9 lines MFC 366844: Mark asymmetric cryptography via OCF deprecated for 14.0. Only one MIPS-specific driver implements support for one of the asymmetric operations. There are no in-kernel users besides /dev/crypto. The only known user of the /dev/crypto interface was the engine in OpenSSL releases before 1.1.0. 1.1.0 includes a rewritten engine that does not use the asymmetric operations due to lack of documentation. ------------------------------------------------------------------------ r368320 | jhb | 2020-12-03 17:11:09 -0800 (Thu, 03 Dec 2020) | 4 lines MFC 350813: tools/tools/crypto: cryptokeytest: Fix build with newer OpenSSL Also, drag into this decade. ------------------------------------------------------------------------ r368321 | kevans | 2020-12-03 18:18:40 -0800 (Thu, 03 Dec 2020) | 13 lines MFC r368116: kern: cpuset: drop the lock to allocate domainsets Restructure the loop a little bit to make it a little more clear how it really operates: we never allocate any domains at the beginning of the first iteration, and it will run until we've satisfied the amount we need or we encounter an error. The lock is now taken outside of the loop to make stuff inside the loop easier to evaluate w.r.t. locking. This fixes it to not try and allocate any domains for the freelist under the spinlock, which would have happened before if we needed any new domains. ------------------------------------------------------------------------ r368322 | kevans | 2020-12-03 18:19:45 -0800 (Thu, 03 Dec 2020) | 35 lines MFC r367944: cpuset_setproc: use the appropriate parent for new anon. sets As far as I can tell, this has been the case since initially committed in 2008. cpuset_setproc is the executor of cpuset reassignment; note this excerpt from the description: * 1) Set is non-null. This reparents all anonymous sets to the provided * set and replaces all non-anonymous td_cpusets with the provided set. However, reviewing cpuset_setproc_setthread() for some jail related work unearthed the error: if tdset was not anonymous, we were replacing it with `set`. If it was anonymous, then we'd rebase it onto `set` (i.e. copy the thread's mask over and AND it with `set`) but give the new anonymous set the original tdset as the parent (i.e. the base of the set we're supposed to be leaving behind). The primary visible consequences were that: 1.) cpuset_getid() following such assignment returns the wrong result, the setid that we left behind rather than the one we joined. 2.) When a process attached to the jail, the base set of any anonymous threads was a set outside of the jail. This was initially bundled in D27298, but it's a minor fix that's fairly easy to verify the correctness of. A test is included in D27307 ("badparent"), which demonstrates the issue with, effectively: osetid = cpuset_getid() newsetid = cpuset() cpuset_setaffinity(thread) cpuset_setid(osetid) cpuset_getid(thread) -> observe that it matches newsetid instead of osetid. ------------------------------------------------------------------------ r368323 | kevans | 2020-12-03 18:20:41 -0800 (Thu, 03 Dec 2020) | 15 lines MFC r368006: kern: never restart syscalls calling closefp(), e.g. close(2) All paths leading into closefp() will either replace or remove the fd from the filedesc table, and closefp() will call fo_close methods that can and do currently sleep without regard for the possibility of an ERESTART. This can be dangerous in multithreaded applications as another thread could have opened another file in its place that is subsequently operated on upon restart. The following are seemingly the only ones that will pass back ERESTART in-tree: - sockets (SO_LINGER) - fusefs - nfsclient ------------------------------------------------------------------------ r368324 | kevans | 2020-12-03 18:28:45 -0800 (Thu, 03 Dec 2020) | 26 lines MFC r368009-r368010: kern: cpuset: minor improvements r368009: kern: cpuset: allow cpuset_create() to take an allocated *setp Currently, it must always allocate a new set to be used for passing to _cpuset_create, but it doesn't have to. This is purely kern_cpuset.c internal and it's sparsely used, so just change it to use *setp if it's not-NULL and modify the two consumers to pass in the address of a NULL cpuset. This paves the way for consumers that want the unr allocation without the possibility of sleeping as long as they've done their due diligence to ensure that the mask will properly apply atop the supplied parent (i.e. avoiding the free_unr() in the last failure path). r368010: kern: cpuset: rename _cpuset_create() to cpuset_init() cpuset_init() is better descriptor for what the function actually does. The name was previously taken by a sysinit that setup cpuset_zero's mask from all_cpus, it was removed in r331698 before stable/12 branched. A comment referencing the removed sysinit has now also been removed, since the setup previously done was moved into cpuset_thread0(). ------------------------------------------------------------------------ r368325 | kevans | 2020-12-03 18:37:33 -0800 (Thu, 03 Dec 2020) | 33 lines MFC r367742-r367743: _umtx_op: documentation and compat32 fix r367742: _umtx_op: document UMTX_OP_SEM2_WAIT copyout behavior This clever technique to get a time remaining back was added to support sem_clockwait_np. Reviewed by: kib, vangyzen Differential Revision: https://reviews.freebsd.org/D27160 r367743: _umtx_op: fix a compat32 bug in UMTX_OP_NWAKE_PRIVATE Specifically, if we're waking up some value n > BATCH_SIZE, then the copyin(9) is wrong on the second iteration due to upp being the wrong type. upp is currently a uint32_t**, so upp + pos advances it by twice as many elements as it should (host pointer size vs. compat32 pointer size). Fix it by just making upp a uint32_t*; it's still technically a double pointer, but the distinction doesn't matter all that much here since we're just doing arithmetic on it. Add a test case that demonstrates the problem, placed with the libthr tests since one messing with _umtx_op should be running these tests. Running under compat32, the new test case will hang as threads after the first 128 get missed in the wake. it's not immediately clear how to hit it in practice, since pthread_cond_broadcast() uses a smaller (sleepq batch?) size observed to be around ~50 -- I did not spend much time digging into it. The uintptr_t change makes no functional difference, but i've tossed it in since it's more accurate (semantically). ------------------------------------------------------------------------ r368328 | ume | 2020-12-04 06:09:12 -0800 (Fri, 04 Dec 2020) | 2 lines MFC r368111: fix casper initialization for setting scripts. ------------------------------------------------------------------------ r368339 | kib | 2020-12-04 08:05:31 -0800 (Fri, 04 Dec 2020) | 10 lines Fix msdosfs suspension. Unlike HEAD, stable/12 still uses the check for vfs_susp_clean != NULL as indicator that fs supports suspension. Satisfy the requirement by providing dummy msdosfs_susp_clean method implementation. This is direct commit to stable/12. Reported by: ?zkan KIRIK ------------------------------------------------------------------------ r368346 | cy | 2020-12-04 11:35:43 -0800 (Fri, 04 Dec 2020) | 22 lines Revert r366857. r366857 created a number of problems, tearing down interfaces too early in shutdown. This resulted in: - hung ssh sessions when shutting down or rebooting remotely using shutdown (I've used exec shutdown, for years, as apposed to simply shutdown). - NFS mounted filesystems "disappear" prior to unmount. - dhclient attached to a VLAN on an interface who's parent interface has already shut down prints errors. The path forward is to teach lagg(4) and vlan(4) about WOL. PR: 251531, 251540 PR: 158734, 109980 are broken again Reported by: jhb, emaste, jtl, Helge Oldach Martin Birgmeier Discussion at: https://reviews.freebsd.org/D27459 ------------------------------------------------------------------------ r368361 | kib | 2020-12-05 01:08:26 -0800 (Sat, 05 Dec 2020) | 5 lines MFC r368125: libc: Add pthread_attr_get_np(3) stub, reporting ESRCH. PR: 251112 ------------------------------------------------------------------------ r368376 | gbe | 2020-12-05 23:09:34 -0800 (Sat, 05 Dec 2020) | 12 lines MFC r367900, r367902, r367903 r367900: syslog.conf(5): Fix a few mandoc warnings - new sentence, new line - skipping paragraph macro: Pp at the end of Sh r367902: crashinfo(8): Fix a few mandoc warnings - new sentence, new line r367903: moused(8): Fix a few mandoc warnings - new sentence, new line ------------------------------------------------------------------------ r368377 | gbe | 2020-12-05 23:22:38 -0800 (Sat, 05 Dec 2020) | 8 lines MFC r367898, r367899 r367898: iscsi.conf(5): Fix a mandoc warning - new sentence, new line r367899: snmp_wlan(3): Fix mandoc warnings - new sentence, new line ------------------------------------------------------------------------ r368378 | gbe | 2020-12-05 23:38:58 -0800 (Sat, 05 Dec 2020) | 6 lines MFC r344922 (by wosch): explain ``fsck -f'' more in detail PR: 223491 Approved by: mckusick, 0mp, imp Differential Revision: https://reviews.freebsd.org/D19437 ------------------------------------------------------------------------ r368379 | gbe | 2020-12-05 23:47:10 -0800 (Sat, 05 Dec 2020) | 11 lines MFC r344013 and r344015 (by cracauer) r344013: Clarify NFSv4 /etc/exports semantics, with working example. The existing wording has been confusing users for years. r344015: Bump .Dd for today's edit. Thank you Enji Cooper ------------------------------------------------------------------------ r368380 | gbe | 2020-12-05 23:50:15 -0800 (Sat, 05 Dec 2020) | 8 lines MFC r366572: Fix a few mandoc issues - no blank before trailing delimiter - whitespace at end of input line - sections out of conventional order - normalizing date format - AUTHORS section without An macro ------------------------------------------------------------------------ r368381 | gbe | 2020-12-05 23:55:12 -0800 (Sat, 05 Dec 2020) | 9 lines MFC r366662 (by imp), r367897 r366662: devmatch: First appeared in 12.0 Document that devmatch first appeared in FreeBSD 12.0. Also can't -> can not. But it doesn't help the sentence much. r367897: devmatch(8): Fix section ordering - sections out of conventional order: Sh HISTORY ------------------------------------------------------------------------ r368382 | gbe | 2020-12-05 23:57:56 -0800 (Sat, 05 Dec 2020) | 4 lines MFC r367889: camcontrol(8): Fix some warnings spotted by mandoc - skipping paragraph macro: Pp before Bl ------------------------------------------------------------------------ r368383 | gbe | 2020-12-06 00:01:27 -0800 (Sun, 06 Dec 2020) | 10 lines MFC r367901 and r367904 r367901: hostapd.conf(5): Fix a mandoc warning -new sentence, new line r367904: hostapd.conf(5): Add missing 'l' In r367901 I accidentally deleted the 'l' while fixing a few mandoc erros. Spotted by: Yuri Pankov ------------------------------------------------------------------------ r368389 | eugen | 2020-12-06 08:22:26 -0800 (Sun, 06 Dec 2020) | 16 lines MFC r364027 by arichardson: Fix linker error in libuutil with recent LLVM This also fixes nanobsd-style build (cross-compiling). Original commit log: Not marking the function as static can result in a linker error: undefined reference to __assfail [--no-allow-shlib-undefined] I noticed this error after updating our CHERI LLVM to the latest upstream LLVM HEAD revision. This change effectively reverts r329984 and marks dmu_buf_init_user as static (which keeps the GCC build happy). Reviewed By: #zfs, asomers, freqlabs, mav Differential Revision: https://reviews.freebsd.org/D25663 ------------------------------------------------------------------------ r368401 | kib | 2020-12-06 17:02:20 -0800 (Sun, 06 Dec 2020) | 3 lines MFC r368190: Ensure that threading library is initialized in pthread_mutex_init(). ------------------------------------------------------------------------ r368402 | kib | 2020-12-06 17:05:39 -0800 (Sun, 06 Dec 2020) | 3 lines MFC r368191: ffs: do not read full direct blocks if they are going to be overwritten. ------------------------------------------------------------------------ r368418 | gbe | 2020-12-07 12:36:58 -0800 (Mon, 07 Dec 2020) | 7 lines MFC r350224 by sobomax: Allow "update" option to be used in the fstab(5). Document possible use case. Approved by: sobomax Differential Revision: https://reviews.freebsd.org/D18586 ------------------------------------------------------------------------ r368426 | mav | 2020-12-07 16:58:02 -0800 (Mon, 07 Dec 2020) | 2 lines MFC r367985: Remove unneeded locking around xpt_bus_[de]register(). ------------------------------------------------------------------------ r368427 | kib | 2020-12-07 17:44:16 -0800 (Mon, 07 Dec 2020) | 4 lines MFC r368260: rtld: bump r_debug.r_version to 1 from current 0. Add r_ldbase. ------------------------------------------------------------------------ r368428 | kib | 2020-12-07 17:45:36 -0800 (Mon, 07 Dec 2020) | 3 lines MFC r368262: vfs_aio.c: correct comment. ------------------------------------------------------------------------ r368429 | kib | 2020-12-07 17:46:44 -0800 (Mon, 07 Dec 2020) | 3 lines MFC r368264: vfs_aio.c: style. ------------------------------------------------------------------------ r368430 | kib | 2020-12-07 17:47:59 -0800 (Mon, 07 Dec 2020) | 3 lines MFC r368265: lio_listio(2): send signal even if number of jobs is zero. ------------------------------------------------------------------------ r368437 | yuripv | 2020-12-07 23:47:29 -0800 (Mon, 07 Dec 2020) | 9 lines MFC r340354: Use blank am_pm and t_fmt_ampm for de_AT and de_DE locales as apparently they use 24-hour clock notation. The visible change is that w(1) now uses 24-hour clock format as it checks for t_fmt_ampm presence. PR: 231771 Submitted by: Christoph Sch?nweiler ------------------------------------------------------------------------ r368438 | yuripv | 2020-12-08 00:20:30 -0800 (Tue, 08 Dec 2020) | 11 lines MFC r362147: awk(1): use -version instead of -V -V is OpenBSD specific, use -version instead. While here, fix issue reported by mandoc lint and drop nonexistent script(7) reference. PR: 247004 ------------------------------------------------------------------------ r368459 | emaste | 2020-12-08 10:28:49 -0800 (Tue, 08 Dec 2020) | 14 lines MFC r368447: OpenSSL: address CVE-2020-1971 OpenSSL commit 3db2c9f3: Complain if we are attempting to encode with an invalid ASN.1 template OpenSSL commit 43a7033: Check that multi-strings/CHOICE types don't use implicit tagging OpenSSL commit f960d812: Correctly compare EdiPartyName in GENERAL_NAME_cmp() Obtained from: OpenSSL 3db2c9f3, 43a7033, f960d812 Security: CVE-2020-1971 ------------------------------------------------------------------------ r368466 | rmacklem | 2020-12-08 14:37:30 -0800 (Tue, 08 Dec 2020) | 11 lines MFC: r368268 Improve man page for AmazonEFS mounts. PR#250770 was actually just a misunderstanding of what NFS mount options are needed for AmazonEFS mounts. This patch attempts to clarify the manpage to clarify this. This is a content change. PR: 250770 ------------------------------------------------------------------------ r368469 | emaste | 2020-12-08 16:28:27 -0800 (Tue, 08 Dec 2020) | 14 lines MFC r368397: Add deprecation notice to mn(4) Sync serial (T1/E1) interfaces are largely irrelevant today and phk confirms this driver is unnecessary in review D23928. This leaves ce(4) and cp(4) in the tree. They're likely not relevant either, but glebius contacted the manufacturer and those devices are still available for purchase. At glebius' suggestion leave them in the tree as long as they do not impose a maintenace burden. [Build fix from hps included in MFC] Sponsored by: The FreeBSD Foundation ------------------------------------------------------------------------ r368470 | markj | 2020-12-08 16:56:14 -0800 (Tue, 08 Dec 2020) | 5 lines MFC r368276: pf: Fix table entry counter toggling PR: 251414 ------------------------------------------------------------------------ r368471 | markj | 2020-12-08 16:56:38 -0800 (Tue, 08 Dec 2020) | 3 lines MFC r368278: rtsold: Fix bugs reported by Coverity ------------------------------------------------------------------------ r368477 | grehan | 2020-12-08 18:47:39 -0800 (Tue, 08 Dec 2020) | 3 lines MFC r367762 Add legacy debug/test interfaces for kvm unit tests. ------------------------------------------------------------------------ r368488 | kp | 2020-12-09 09:17:45 -0800 (Wed, 09 Dec 2020) | 9 lines MFC r368277: pf tests: Test case for bug #251414 Changing a table from not having counters to having counters (or vice versa) may trigger panics. PR: 251414 ------------------------------------------------------------------------ r368491 | asomers | 2020-12-09 12:06:37 -0800 (Wed, 09 Dec 2020) | 18 lines ZFS: fix spurious EBUSY after zfs receive to an existing dataset If you do a "zfs send -p | zfs receive -F " to an existing but empty dataset, the receive will complete successfully but spuriously fail with exit status 1 and the message "cannot mount 'pool/dataset': mountpoint or dataset is busy". The root cause is a merge error made in r344569 and MFCed in r345578, which merged changes a10d50f999 and e63ac16d25 from ZoL. The merge: * failed to flip a == to an != like the upstream change did, and * Left out one chunk Direct commit to stable/12 because head has moved on to OpenZFS. PR: 251694 Reviewed by: bapt Sponsored by: Axcient ------------------------------------------------------------------------ r368494 | mckusick | 2020-12-09 14:37:23 -0800 (Wed, 09 Dec 2020) | 6 lines MFC of 368396 and 368425. Document BA_CLRBUF flag. Sponsored by: Netflix ------------------------------------------------------------------------ r368495 | cy | 2020-12-09 16:43:33 -0800 (Wed, 09 Dec 2020) | 4 lines MFC r368294: Remove trailing whitespace. ------------------------------------------------------------------------